janhoy opened a new pull request, #4605:
URL: https://github.com/apache/solr/pull/4605
Three latent bugs surfaced by the Error Prone 2.50.0 upgrade in #4604, split
out into their own PR per review feedback there:
- **ZkMaintenanceUtils**: compared `Path` objects with `==` in the
single-file-upload case, so the intended branch was never guaranteed to be
taken.
- **HttpShardHandler**: compared a request-context `Boolean` with `==`; now
`Boolean.TRUE.equals(...)` so any `true` value enables `onlyNrt`.
- **ZkShardTermsTest.waitFor**: compared boxed values by reference, always
burning the 10s timeout for values outside the `Integer` cache.
Also documents (with a `@SuppressWarnings("ReferenceEquality")`) that the
ClassLoader cache guard in `Utils` intentionally uses identity comparison.
#4604 will suppress these findings with TODO comments pointing here; once
this merges, that branch drops the TODOs on rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
