janhoy commented on code in PR #4606: URL: https://github.com/apache/solr/pull/4606#discussion_r3520648418
########## changelog/unreleased/PR#4606-charset-api-modernization.yml: ########## @@ -0,0 +1,8 @@ +# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc +title: Modernize String-based charset APIs to java.nio.charset.Charset; invalid client-supplied charset names are still handled as I/O errors +type: fixed Review Comment: Ah, Claude suggested other, I flipped it to fixed since it's kind of a fix of new policy. But I'll flip-flop it back.. ```suggestion type: other ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
