[
https://issues.apache.org/jira/browse/SOLR-18296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18093531#comment-18093531
]
ASF subversion and git services commented on SOLR-18296:
--------------------------------------------------------
Commit 19a09bbc164982859d08059c265d4af1559a65c6 in solr's branch
refs/heads/branch_10x from Serhiy Bzhezytskyy
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=19a09bbc164 ]
SOLR-18296: google-java-format: upgrade to 1.35.0 and reformat (JDK 24/25 fix)
(#4578)
(cherry picked from commit 554a731c60c1f94c556a04daa822bf4628d62ddb)
> Upgrade google-java-format to 1.35.0 (fixes JDK 24/25 build break)
> ------------------------------------------------------------------
>
> Key: SOLR-18296
> URL: https://issues.apache.org/jira/browse/SOLR-18296
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Serhiy Bzhezytskyy
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Solr's spotless/tidy pins google-java-format 1.18.1
> (gradle/libs.versions.toml).
> That version calls javac internals —
> Log$DeferredDiagnosticHandler.getDiagnostics() — whose signatures changed in
> JDK 24, so `gradlew tidy` / `spotlessApply` throws NoSuchMethodError on JDK
> 24+. google-java-format 1.34.0+ adds support for the newer JDKs; 1.35.0 is
> the current release.
> This bumps google-javaformat 1.18.1 -> 1.35.0. The Java baseline is unchanged
> (JDK 21); this only affects the spotless code formatter.
> Scope:
> - gradle/libs.versions.toml: google-javaformat 1.18.1 -> 1.35.0
> - re-running the formatter (`gradlew tidy`) reformats ~35 files (minor,
> mechanical — the new version's formatting rules)
> - spotless (8.3.0) drives the new formatter version with no other change
> Verified on Eclipse Temurin 21 and JDK 25: `gradlew spotlessJavaCheck` passes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
