kotman12 opened a new pull request, #4625:
URL: https://github.com/apache/solr/pull/4625

   # Description
   
   Reproducing the stuck-overseer bug caused by close vs start data race. 
Previously overseer would enter leader election only on session expiry. By 
triggering election on every reconnect we uncovered certain latent bugs that 
were relatively rare to hit before but are now a lot more common.
   
   # Solution
   
   Returning to previous behavior may be a good place to start, see 
https://github.com/apache/solr/pull/4577. I think it is still possible to hit 
this condition even if you run leader election on session expiry with a really 
ill-timed reconnect that happens exactly on session boundary. I will try to see 
what we can do here keeping in mind the uncertainty around the future of 
overseer.
   
   # Tests
   
   * testOverseerSurvivesZkReconnect
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [ ] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [ ] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   - [ ] I have added a [changelog 
entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my 
change
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to