Serhiy Bzhezytskyy created SOLR-18308:
-----------------------------------------
Summary: Make UpdateErrorHandler the preferred error-reporting
mechanism for ConcurrentUpdate*SolrClient; consider requiring it in 11
Key: SOLR-18308
URL: https://issues.apache.org/jira/browse/SOLR-18308
Project: Solr
Issue Type: Improvement
Components: clients - java
Reporter: Serhiy Bzhezytskyy
Follow-up to SOLR-3284 (PR #4632), which added an optional UpdateErrorHandler
to the
ConcurrentUpdate*SolrClient Builder: onError(Throwable, List<String> failedIds,
String collection), with the pre-existing log-only behavior as the default when
no handler is registered.
In review, dsmiley proposed going further: "IMO we probably want to make this
new errorHandler the preferred mechanism... maybe even eventually mandatory in
11. (I'm +1)"
Sketch:
1. 10.x — document the handler as the preferred mechanism (javadoc + ref
guide); consider a deprecation note on relying on the log-only default and/or
overriding handleError directly.
2. 11.0 — decide whether an explicit handler becomes required at build time,
and what happens to the protected handleError path.
Open questions for discussion:
* migration notes for existing handleError subclassers;
* whether "mandatory" means builder-enforced (fail fast without a handler) or
just removal of the silent log-only default.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
