dsmiley commented on code in PR #4574: URL: https://github.com/apache/solr/pull/4574#discussion_r3598598190
########## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ########## @@ -93,6 +93,14 @@ It is intended as a temporary measure while you migrate the affected accounts to HttpSolrClient returns; this time as a base class for HttpJettySolrClient and HttpJdkSolrClient. Its builder will dynamically detect if solr-jetty is available and use that, otherwise it will use the JDK client. +=== Embedded Jetty Configuration + +Solr 10.1 upgrades the embedded server to Eclipse Jetty 12.1, which removed Jetty's directory-scanning deployer (the `DeploymentManager` and `ContextProvider` classes). +Because Solr serves a single, statically-known webapp, that webapp is now deployed directly in `server/etc/jetty.xml`, and the `server/contexts/solr-jetty-context.xml` file has been removed. + +Advanced users who relied on Jetty scanning the `server/contexts/` directory to auto-deploy additional context descriptors will find that this no longer happens. +To deploy an extra context, or to customize how the Solr webapp itself is deployed, edit `server/etc/jetty.xml` directly and add the context there. + Review Comment: @janhoy IMO the word choice of "Embedded" here is unfortunate and should be removed to reduce possible confusion. For a moment I was thinking EmbeddedSolrServer or JettySolrRunner. I don't think we should refer to Solr's use of Jetty as "embedded", even though I can see how someone might choose such a word. We needn't come up with a substitute word. Just simply refer to Solr's Jetty server configuration, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
