[
https://issues.apache.org/jira/browse/SOLR-18251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18097444#comment-18097444
]
Vadim Kirilchuk commented on SOLR-18251:
----------------------------------------
[~dsmiley] I updated the PR, merging some of the changes from the Sanjay's PR.
* Replaced DVFTUtil with methods in FieldType as you suggested
* Updated changelog
* Added negative tests for conflicting flags
I did not copy
[https://github.com/apache/solr/pull/4458/changes#diff-d5fd24e3eb4ba705634df56037b4a02a7c16b0dad8ac421b3402d527774c2756]
from Sanjay's PR as I think DocValuesSkipListTest covers proper
DocValuesSkipIndexType being set on the lucene field. Let me know if you want
me to copy that TestCodecSupport changes.
Outstanding questions are:
* Schema version. "What needs to be done to schema version? I bumped to 1.8 in
the test, but not sure what's the general guidance on that."
* The DocValuesSkipListTest, I need some guidance on what we want to test
besides checking FieldInfo docValuesSkipIndexType. I left some basic range
querying for some basic fields, but if we want comprehensive test it should
query for all the field types.
** I also wonder what to do with ICUCollationField as it sits in separate
module, do we need a separate test there, or do we want to bring it into
DocValuesSkipListTest somehow?
Anything else we want to have in the PR, besides waiting for Sanjay's
performance testing results?
> Add Solr schema support for DocValues skip lists
> ------------------------------------------------
>
> Key: SOLR-18251
> URL: https://issues.apache.org/jira/browse/SOLR-18251
> Project: Solr
> Issue Type: Task
> Components: Schema and Analysis
> Affects Versions: 10.1
> Reporter: Sanjay Dutt
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Lucene introduced optional skip lists on top of DocValues in
> apache/lucene#13449. The feature is exposed through the {{DocValuesSkipper}}
> abstraction and is controlled by a Lucene {{FieldType}} flag.
> Solr currently exposes DocValues through schema configuration, but does not
> provide a schema-level option to enable this DocValues skip list support.
> This issue proposes adding an opt-in Solr schema option, such as:
> {code:java}
> docValuesSkipList="true"{code}
> Example:
> {code:java}
> <field name="price"
> type="plong"
> indexed="false"
> docValues="true"
> docValuesSkipList="true" />{code}
> The Lucene PR notes that this can be efficient when the index is sorted and
> the field belongs to the index sorting.
> The actual benefit depends on data layout and query pattern, so this should
> be exposed as an opt-in feature.
> Only compatible DocValues field types should allow this option. Based on the
> Lucene PR, this applies to DocValues types such as {{{}NUMERIC{}}},
> {{{}SORTED_NUMERIC{}}}, {{{}SORTED{}}}, and {{{}SORTED_SET{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
