dsmiley commented on code in PR #4667: URL: https://github.com/apache/solr/pull/4667#discussion_r3651183645
########## solr/core/src/java/org/apache/solr/metrics/OtelRuntimeJvmMetrics.java: ########## Review Comment: CC @mlbiscoc ########## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ########## Review Comment: seemed totally uninteresting to me ########## solr/server/solr/configsets/_default/conf/solrconfig.xml: ########## Review Comment: By commenting out the whole listener, it's never loaded and thus doesn't log ########## solr/core/src/java/org/apache/solr/cloud/SolrZkServer.java: ########## Review Comment: just a simplification here. Both sides of the if were the same! No doubt after some previous change. ########## solr/server/solr/zoo.cfg: ########## @@ -32,5 +32,8 @@ syncLimit=5 # Set to "0" to disable auto purge feature #autopurge.purgeInterval=1 +# 0 is ZK's default, means unlimited +maxCnxns=0 Review Comment: ZK classes observed this was *not* set and logged that we didn't set it. Oooookaaaay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
