[
https://issues.apache.org/jira/browse/SOLR-18234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18099194#comment-18099194
]
Jalaz Kumar commented on SOLR-18234:
------------------------------------
Hi [~dsmiley] [~epugh]
I have started working on this task with the final goal of moving CLI out of
core into a dedicated module of itself. There is some coupling that i observed
between the classes that lies in core, few are in packagemanager over the CLI
package, thus there will be few series of PRs in which I would to proceed.
During this course, I would also gain understanding of the CLI module working &
do some code wise improvement or bug fixes or test enhancements.
let me know if this sounds nice.
On that way ahead, I have raised 1 PR:
[https://github.com/apache/solr/pull/4663] which organises the cli package
better. I will be spending some time to understand the internals of this
package next.
> core-cli build module
> ---------------------
>
> Key: SOLR-18234
> URL: https://issues.apache.org/jira/browse/SOLR-18234
> Project: Solr
> Issue Type: Task
> Reporter: David Smiley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The "org.apache.solr.cli" package ought to be separated to a module (gradle
> sub-project), e.g. "core-cli", adjacent to "core". Motivation: reduce
> dependencies of solr-core[1], and reduces the size/scope of our largest
> module[2].
> [1]: even though Solr will certainly ship with this JAR and its dependencies:
> (a) they won't go/belong in WEB-INF/lib and won't be on Solr's runtime
> classpath, (b) anyone embedding Solr-core won't need CLI or its dependencies,
> and (c) also applies to users of solr-test-framework
> [2]: The gradle build can run a bit more efficiently when our largest
> sub-project is reduced in size for a variety of reasons
> [3]: new dirs are likely useful for misc things like an AGENTS.md, README.md,
> maybe referencing in CODEOWNERS and misc things.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
