psalagnac commented on code in PR #4669:
URL: https://github.com/apache/solr/pull/4669#discussion_r3655735050
##########
solr/solrj/src/java/org/apache/solr/common/util/JsonRecordReader.java:
##########
@@ -218,13 +211,13 @@ private void buildOptimize() {
private void build(
List<String> paths, // a List of segments from the split paths
String fieldName, // the fieldName assoc with this path
- boolean multiValued, // flag if this fieldName is multiValued or not
+ // flag if this fieldName is multiValued or not
Review Comment:
Comment to be removed
##########
solr/core/src/test/org/apache/solr/response/JSONWriterTest.java:
##########
@@ -187,10 +187,9 @@ public void testJSONSolrDocument() throws Exception {
@Test
public void testArrntvWriterOverridesAllWrites() {
// List rather than Set because two not-overridden methods could share
name but not signature
- final List<String> methodsExpectedNotOverridden = new ArrayList<>(14);
+ final List<String> methodsExpectedNotOverridden = new ArrayList<>(13);
Review Comment:
Minor: Why not just using the default constructor here? Mostly in test code,
such a micro optimization does not make sense to me.
Plus the following lines add more than 13 items, so the array will have to
grow anyway.
##########
solr/solrj/src/java/org/apache/solr/common/Callable.java:
##########
@@ -17,5 +17,5 @@
package org.apache.solr.common;
public interface Callable<T> {
Review Comment:
I see a single internal class using this interface.
We could remove it and replace it by Java standard `Consumer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
