serhiy-bzhezytskyy commented on PR #60: URL: https://github.com/apache/solr-orbit/pull/60#issuecomment-5092820829
Thanks Jan. On auto-resolving the workload from the stored test run — agreed, a separate improvement. This PR keeps to the parity fix (`run` accepts a workload source, `aggregate` should too); I can open a follow-up issue for the auto-resolve idea so it isn't lost. On the docs: you're right, and it's slightly worse than it looks. The two pages disagreed with each other — `command-flags.md` already listed `--workload-repository` under "aggregate flags", while `reference/commands/aggregate.md` documented only `--test-runs`, `--test-runs-id` and `--results-file`. Neither page mentioned `--workload-revision`, which `aggregate` has accepted all along, since it calls the same `add_workload_source()` helper as `run`. Pushed a commit documenting all three on both pages, using the wording already used for `run`. `--workload-path` and `--workload-repository` are mutually exclusive (argparse group), so they read the same way there as elsewhere. Worth noting this doc gap is probably why the parity gap went unnoticed: with `--workload-repository` undocumented on that page, the absence of `--workload-path` beside it wasn't visible to a reader. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
