epugh commented on code in PR #4672:
URL: https://github.com/apache/solr/pull/4672#discussion_r3659300886


##########
solr/core/src/java/org/apache/solr/cli/CreateTool.java:
##########
@@ -314,6 +278,26 @@ protected void createCollection(CloudSolrClient 
cloudSolrClient, CommandLine cli
     echo(endMessage);
   }
 
+  /** Zips the contents of a configset directory for upload via the Configsets 
V2 API. */

Review Comment:
   Okay, turns out that the zero byte issue was when you use a `zip` command on 
the terminal on certain os'es...   So if you make your own zip file, and then 
upload it.  But this is a directory, and since we do our own zipping, it 
doesn't trigger the issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to