epugh commented on code in PR #4669:
URL: https://github.com/apache/solr/pull/4669#discussion_r3669505852
##########
solr/solrj/src/java/org/apache/solr/common/SolrException.java:
##########
@@ -23,14 +23,10 @@
import java.util.Map;
import org.apache.solr.common.util.NamedList;
import org.apache.solr.common.util.SimpleOrderedMap;
-import org.slf4j.Logger;
-import org.slf4j.MDC;
/** */
public class SolrException extends RuntimeException {
- private final Map<String, String> mdcContext;
Review Comment:
thanks for explaining this, that DOES make sense. It's one of those
things, there are no tests around it, we don't use that behavior in our own
SolrJ use, so it feels like it's a "YAGNI" type feature! and that if someone
DID dpeend on it, it would probably break at some point.
I will leave this PR Open for a few more days, see if there are any other
opionons.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
