dsmiley commented on code in PR #4626:
URL: https://github.com/apache/solr/pull/4626#discussion_r3670896438
##########
solr/solrj-jetty/src/java/org/apache/solr/client/solrj/jetty/HttpJettySolrClient.java:
##########
@@ -301,7 +301,7 @@ private HttpClient createHttpClient(Builder builder) {
asyncTracker.getMaxRequestsQueuedPerDestination());
httpClient.setUserAgentField(new HttpField(HttpHeader.USER_AGENT,
USER_AGENT));
httpClient.setConnectTimeout(builder.getConnectionTimeoutMillis());
- httpClient.setIdleTimeout(-1); // don't enforce an idle timeout at this
level
+ httpClient.setIdleTimeout(SolrHttpConstants.DEFAULT_SO_TIMEOUT);
Review Comment:
I suppose we should consider this an experiment that the build may prove
out? We want to make it possible to choose a longer idle timeout in the
builder, I'd think. If a longer one is chosen, it won't work; it'll be
effectively capped at this amount. On the other hand... if this works great
except for this limitation, and doesn't seem like a big limitation, then maybe
this is the price to pay.
Also... the comment you removed is still partially relevant.
##########
changelog/unreleased/SOLR-17433-changed-default-request-timeout.yml:
##########
@@ -1,6 +1,7 @@
title: >
SolrClients no longer have a default request timeout. It was problematic
with streaming expressions.
The idle timeout remains, albeit the JDK HttpClient doesn't support that
(has none).
+ Changed the Jetty's default idle timeout to 10 mins as infinite timeout
causes tests to hang infinitely.
Review Comment:
At this stage; I don't think we quite know exactly what we're doing, in
order to then ponder how best to communicate it. And even then, the tests is
not why we're doing this. In the changelog we communicate the impact to users
(such as yourself perhaps).
So lets defer this till the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
