dsmiley commented on code in PR #4677: URL: https://github.com/apache/solr/pull/4677#discussion_r3670983129
########## build-tools/build-infra/declare-repositories.gradle: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// Central repository declarations for every consumption scope: plugin resolution +// (pluginManagement), project dependencies, buildscript classpath, and the +// build-infra / missing-doclet included builds. Applied via +// `apply from: <this>, to: <handler>` onto whichever object owns the repositories. +// +// Enterprise mirror: set the `solr.maven.repo.url` system property (via +// -Dsolr.maven.repo.url=..., or systemProp.solr.maven.repo.url=... in gradle.properties) or +// the equivalent SOLR_MAVEN_REPO_URL environment variable to route every scope through a +// single internal mirror (e.g. Artifactory/Nexus) instead of public repositories. System +// properties and environment variables are inherited by the included builds, so one setting +// covers the entire build. + +def mirrorUrl = System.getProperty('solr.maven.repo.url') ?: System.getenv('SOLR_MAVEN_REPO_URL') + +repositories { + if (mirrorUrl) { + maven { + name = 'enterpriseMirror' Review Comment: it can be removed but seems a best practice / helpful. I'll leave it commented and put "yourEnterpriseMirror" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
