[
https://issues.apache.org/jira/browse/SOLR-9355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18100271#comment-18100271
]
David Smiley commented on SOLR-9355:
------------------------------------
Fantastic analysis – I especially like the table and cross code analysis,
meaning you looked at several points across Solr that is pertinent. I sense we
should standardize the code to be more harmonious.
This issue is title is very confusing/misleading IMO. Erick doesn't state that
me means specifically when a CUSC is used within Solr for distributed update
processing. My first reading was quite puzzled at how a client (outside Solr)
could possibly put a replica into recovery. Furthermore, CUSC isn't SolrCloud
aware – by design.
> ConcurrentUpdateSolrClient does not retry sending docs to followers
> -------------------------------------------------------------------
>
> Key: SOLR-9355
> URL: https://issues.apache.org/jira/browse/SOLR-9355
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.3
> Reporter: Erick Erickson
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I'm a little out of my comfort zone, so mostly posting this for discussion.
> If, for any reason, ConcurrentUpdateSolrClient doesn't get a response from a
> replica (say a network glitch or the like), it _seems_ to initiate a LIR on
> the replica. This is around line 243 in 5.3.2, and the corresponding code in
> 6x looks unchanged on a quick perusal.
> This is fragile in the sense that a simple retry could avoid the replica
> going into recovery if the problem is transient.
> Whether there is retrying higher in the stack I'm not quite sure, but we're
> seeing this behavior in the field so I'm posting this here for discussion,
> I've had a back-channel discussion already so a JIRA seems in order.
> The other thing I'm not entirely sure of is whether retrying at this point in
> the process is something that will avoid versioning problems.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
