epugh commented on code in PR #4688:
URL: https://github.com/apache/solr/pull/4688#discussion_r3690699332
##########
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##########
@@ -147,201 +165,178 @@ public Options getOptions() {
.addOptionGroup(getConnectionOptions());
}
- private void ensureArgumentIsValidBooleanIfPresent(CommandLine cli, Option
option) {
- if (cli.hasOption(option)) {
- final String value = cli.getOptionValue(option);
- if (!"true".equalsIgnoreCase(value) && !"false".equalsIgnoreCase(value))
{
- echo(
- "Argument ["
- + option.getLongOpt()
- + "] must be either true or false, but was ["
- + value
- + "]");
- runtime.exit(1);
- }
+ private void ensureArgumentIsValidBooleanIfPresent(String optionName, String
value) {
Review Comment:
eventually this will be a shared util method right? Fine for now ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
