epugh commented on PR #4686: URL: https://github.com/apache/solr/pull/4686#issuecomment-5143725108
> I held back from updating many callers of setPath to use the QueryRequest constructor, which is nicer IMO. Just looking at the diff, I would urge you to keep updating the many callers.. It's just so much more readable, and we need to get to the other side of having two ways of doing things... This looks great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
