adityamparikh opened a new pull request, #178: URL: https://github.com/apache/solr-mcp/pull/178
Every item was checked against the repository, not just reworded. **Wrong symbols and paths** — `CollectionService` is in `collection/`, not `metadata/`; `@McpToolParameter` should be `@McpToolParam`; the document-creator roles were inverted (formats implement `SolrDocumentCreator` and register with `IndexingDocumentCreator`); `publish-mcp.yml` does not exist; the observability test README documented `InMemorySpanExporter` and `ObservabilityTestConfiguration`, **neither of which exists anywhere except that README**; `ARCHITECTURE.md` listed `*DirectTest` files that do not exist and called record DTOs POJOs; `FAQ.md` claimed 27 tools when there are 11. **Commands that do not work as written** — `TROUBLESHOOTING.md` piped STDIO logs with `2>&1`, merging diagnostics into the stdout JSON-RPC stream; `ATR_TESTING_GUIDE.md` ran `ls -lh build/distributions/` *after* cd-ing into that directory, and referenced `trstringer/manual-approval@v1` when ASF's allow-list matches by exact SHA; `DEPLOYMENT.md` curled `/actuator/info` unauthenticated when only `/actuator/health` is `permitAll`; `DOCKER_PUBLISHING.md` passed credentials via `-Djib.to.auth.*`, putting tokens in the process argument list; `init-solr.sh` declared `"add-field"` **twice in one JSON object**, so the `name` field was never created; `get-auth0-token.sh` **sourced .env**, executing whatever it contained; `benchmark-native.sh` guarded premature exit with `docker inspect >/dev/null`, which also succeeds for an *exited* container. **Stale statements and data** — `stdio.md` described the trust boundary as the direct parent process; `books` is documented as having sample data but is created empty; a contributor's real Auth0 tenant URL was committed; `devnexus-2026.json` labelled Atlanta local times with a `Z` suffix — all 116 records converted to true UTC instants, keeping the `Z` that Solr's date parsing requires (`ConferenceEndToEndIntegrationTest`, which indexes this file, still passes). **Rejected after verification** — the `date +%s%N` portability claim (modern BSD date supports `%N`) and the `gpg --verify` loop (GnuPG strips `.asc` and locates the payload; tested with a throwaway key). The `docs/specs/graalvm-native-image.md` correction is omitted since that file was pruned by #156. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
