adityamparikh commented on PR #133:
URL: https://github.com/apache/solr-mcp/pull/133#issuecomment-5160482067
Follow-up stacked on this PR: **#179**, which marks the six test packages
this
one leaves unmarked (`server` root, `collection`, `config`, `indexing`,
`schema`, `search`). Together they take the test tree from 2/8 packages
marked
to 8/8, matching what this PR's summary describes as "main and test alike".
No action needed here — #179 is based on this branch, so its diff currently
shows these commits too and will collapse to its own six files once this
merges. Reviewing this one first is the right order.
One correction worth folding in here rather than there, since the line
belongs
to this PR: the new `build.gradle.kts` comment estimates `~30` test sites
behind the `compileTestJava` disable. Measured on the stacked branch, the
actual count is **48 errors across 14 test files** (temporarily replacing the
`options.errorprone.disable("NullAway")` line and running `./gradlew
compileTestJava --rerun-tasks`). Same conclusion — still a follow-up, not a
rider — just a bigger follow-up than the comment implies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
