dsmiley commented on code in PR #4697:
URL: https://github.com/apache/solr/pull/4697#discussion_r3706738028
##########
solr/modules/opentelemetry/src/test-files/solr/tracing/TestDistributedTracing/testRealTimeGetTlogLeaderShortCircuit.json:
##########
Review Comment:
IMO tracing is a nice way to show the byproduct of this optimization.
Without the optimization, there wold be another embedded span for another HTTP
request
##########
solr/core/src/java/org/apache/solr/handler/component/CloudReplicaSource.java:
##########
@@ -171,10 +171,8 @@ private List<String> findReplicas(
.filter(replica -> replica.isActive(clusterState.getLiveNodes()))
.filter(
replica ->
- !builder.onlyNrt
- || (replica.getType() == Replica.Type.NRT
- || (replica.getType() == Replica.Type.TLOG
Review Comment:
the TLOG check was needless and isn't friendly to custom/evolving replica
types, even though admittedly unlikely.
##########
solr/core/src/java/org/apache/solr/handler/component/CloudReplicaSource.java:
##########
@@ -275,7 +273,7 @@ static class Builder {
private String collection;
private ZkStateReader zkStateReader;
private SolrParams params;
- private boolean onlyNrt;
+ private boolean onlyRtg;
Review Comment:
onlyNrt is misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
