janhoy commented on code in PR #4695:
URL: https://github.com/apache/solr/pull/4695#discussion_r3708680360
##########
solr/core/src/java/org/apache/solr/cli/PackageTool.java:
##########
@@ -292,6 +210,122 @@ public void runImpl(CommandLine cli) throws Exception {
}
}
+ private void addRepo(String repoName, String repoUrl) throws Exception {
+ repositoryManager.addRepository(repoName, repoUrl);
+ printGreen("Added repository: " + repoName);
+ }
+
+ private void addKey(Path keyFile) throws Exception {
+ repositoryManager.addKey(Files.readAllBytes(keyFile),
keyFile.getFileName().toString());
+ }
+
+ private void listInstalled() throws Exception {
+ printGreen("Installed packages:\n-----");
Review Comment:
No functional change here, just refactor for ease of migration.
Once we are fully on picocli I agree it would be nice to investigate using a
Terminal/TUI library to aid in formatting/colorizing or providing tabular
output or what not..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
