epugh opened a new pull request, #4709: URL: https://github.com/apache/solr/pull/4709
https://issues.apache.org/jira/browse/SOLR-18188 # Description I noticed that the nightly main builds on jenkins have been failing for a bit: https://ci-builds.apache.org/job/Solr/job/Solr-NightlyTests-main/1878/ I looked and saw two tests. I asked Claude to dig in, and it came back the work in SOLR-18188 as the probably cause. Did some testing, and here is what makes a reproducible failure on main, and a fix on this branch: ./gradlew :solr:core:test --tests "org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest" \ -Ptests.nightly=true -Ptests.seed=DEAD00000000004 --rerun-tasks `-Ptests.seed=DEAD00000000004` and `DEAD00000000005` are seeds that draw `runFullThrottle=true` and reliably reproduce the `HttpJettySolrClient` leak without the fix. With the fix applied, both pass. Seeds that draw `runFullThrottle=false` (e.g. `DEAD00000000001`) pass either way, so use one of the two seeds above to exercise the affected path. # Solution Claude and I looked and he recommended this `IOUtils.closeQuietly`. # Tests Ran the failing test on branch, it passes, on main, it fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
