dsmiley commented on code in PR #4652: URL: https://github.com/apache/solr/pull/4652#discussion_r3717470367
########## solr/core/src/java/org/apache/solr/search/DisMaxQParser.java: ########## Review Comment: Idea: I'm thinking that we want to know how many clauses are are in the DisjunctionMaxQuery of the _parsed_ userQuery. If it's one (or no DMQ) then there were no whitespace separated components, and no need for phrase boost. At this stage right here, we only have the String version of userQuery, so we don't know. Rather than do parser-like things here by inspecting the string, we can probably avoid this as redundant/hacky given we're going to already parse teh userQuery anyway. We can inspect a parsedQuery. Inspecting a String is not idea. So where I'm going with this is, update the caller (who has the parsedUserQuery) to inspect it and conditionally call getPhraseQuery. Then I think you won't even be modifying getPhraseQuery. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
