janhoy commented on code in PR #4710:
URL: https://github.com/apache/solr/pull/4710#discussion_r3730781660
##########
solr/core/src/java/org/apache/solr/cli/SolrProcessManager.java:
##########
@@ -237,11 +281,15 @@ private static List<String> arguments(ProcessHandle ph) {
}
}
- /** Represents a running Solr process */
- public record SolrProcess(long pid, int port, boolean isHttps) {
+ /**
+ * Represents a running Solr process. The {@code host} is the host to use
when connecting to the
+ * process from the local machine, i.e. the advertised host if set, else the
bind host if bound to
+ * a specific address, else {@code localhost}.
+ */
+ public record SolrProcess(long pid, int port, boolean isHttps, String host) {
Review Comment:
Gone is all the bean boiler plate!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
