risdenk commented on code in PR #4577:
URL: https://github.com/apache/solr/pull/4577#discussion_r3777620551
##########
solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContext.java:
##########
@@ -164,7 +164,8 @@ void runLeaderProcess(boolean weAreReplacement) throws
KeeperException, Interrup
if (shouldAbort()) {
// Solr is shutting down or the ZooKeeper session expired while
waiting for replicas. If the
- // later, we cannot be sure we are still the leader, so we should bail
out. The OnReconnect
+ // later, we cannot be sure we are still the leader, so we should bail
out. The
+ // OnExpiredReconnection
// handler will re-register the cores and handle a new leadership
election.
Review Comment:
nit - if you put line 168 and 169 together and `./gradlew tidy` it will
reflow the comment nicely again instead of the extra line break here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
