serhiy-bzhezytskyy opened a new pull request, #4752: URL: https://github.com/apache/solr/pull/4752
https://issues.apache.org/jira/browse/SOLR-18384 # Description `ShardParams.SHARD_URL` has been deprecated since 10.0; the javadoc says it "was an internally used param, never meant for clients to specify; it is no longer used by Solr". # Solution Removed the constant together with its javadoc block. It has no callers: `SHARD_URL` occurs once in the tree, its own declaration, and `shard.url` appears nowhere in code, tests, the reference guide or config. `ShardParams` is left with no deprecated members. Co-authored-by: Claude Opus 5 (1M context) <[email protected]> # Tests No test changed, because nothing referenced the constant. `gradlew check -x test` passes on `0a0c25046ea` with JDK 21, including `forbiddenApis`, `licenses`, `ecjLint`, `spotless`, `renderJavadoc`, `validateSourcePatterns` and `validateLogCalls`. I excluded two things and want to be explicit about them rather than tick the box below: `rat` reports 138 licence-header findings on an untouched `main`, and the Antora site tasks need a real git repository rather than the git worktree I built in. # Checklist - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. — ran it minus `rat` and the Antora tasks, see Tests above - [ ] I have added tests for my changes. — none needed; the constant had no callers - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) — the constant is not documented there - [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
