adityamparikh commented on PR #103: URL: https://github.com/apache/solr-mcp/pull/103#issuecomment-5341806653
Rebased onto `main` (`a84033b`). Conflict resolution: `main` had since marked `getCacheMetrics`/`getHandlerMetrics` as `public @Nullable` (they return `null` when the metrics endpoint is unavailable, e.g. Solr 10). I kept the `@Nullable` and applied only the visibility reduction, so both are now package-private *and* still annotated. I also re-checked that the narrowing is actually safe: every caller of all four methods — `buildIndexStats`, `buildQueryStats`, `getCacheMetrics`, `getHandlerMetrics` — lives in `org.apache.solr.mcp.server.collection`, production and test alike (`CollectionServiceTest`, `CollectionServiceIntegrationTest`). Nothing outside the package refers to them, so package-private costs no test access. Verified: `./gradlew build` green on JDK 25. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
