dsmiley commented on code in PR #4750:
URL: https://github.com/apache/solr/pull/4750#discussion_r3813390087
##########
solr/modules/clustering/src/java/org/apache/solr/handler/clustering/FlatKeysAttrVisitor.java:
##########
Review Comment:
wow; lots of random changes outside of deprecation
##########
solr/core/src/java/org/apache/solr/legacy/BBoxStrategy.java:
##########
Review Comment:
Arguably this entire package can be seen as having a consistent status: The
code is associated with "Trie" numerics. Anticipated to be fully resolved
(replacements) for Solr 11. @HoustonPutman is leading the way here with
progress.
Maybe the BBox stuff could separately be decoupled from that and be ported
to Points + NumericDocValues but someone has not undertaken that.
##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
Review Comment:
These deprecated methods were deprecated on 10.0; look at branch_10_0 to see
for yourself. Thus we may remove them anytime in 10.x. 9.x had no alternative
so devs that worked on this didn't deprecate there.
##########
solr/modules/analysis-extras/src/java/org/apache/solr/schema/ICUCollationField.java:
##########
Review Comment:
lets keep such changes outside of a big PR
##########
solr/modules/analysis-extras/src/java/org/apache/solr/schema/ICUCollationField.java:
##########
@@ -105,9 +105,9 @@ public class ICUCollationField extends FieldType {
private static void warnOrFailUdvas(boolean failHardOnUdvas) {
// NOTE: it may seem odd that we're checking these conditions ourselves
rather than relying on
- // the internal
- // checking of `assertWarnOrFail(...)`. But the main reason we're logging
this error via
- // `XMLConfigFile.assertWarnOrFail(...)` is because this is at its root an
xml config file
+ // the internal checking of `assertWarnOrFail(...)`. But the main reason
we're logging this
+ // error via
+ // `XMLConfigFile.assertWarnOrFail(...)` is because this is at its root a
xml config file
Review Comment:
reflow. Don't even know why this was touched.
##########
AGENTS.md:
##########
@@ -65,6 +65,16 @@ Solr issues are tracked at https://issues.apache.org/jira
(project key `SOLR`).
- Search: `curl
"https://issues.apache.org/jira/rest/api/2/search?jql=<url-encoded
JQL>&fields=summary,status,resolution&maxResults=10"` with JQL like
`project=SOLR AND text~"some phrase" ORDER BY updated DESC`
- Single issue (with comments): `curl
"https://issues.apache.org/jira/rest/api/2/issue/SOLR-12345?fields=summary,description,comment"`
+## Git Repository History
Review Comment:
```suggestion
## Git Branches and Repository History
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
