serhiy-bzhezytskyy opened a new pull request, #4772: URL: https://github.com/apache/solr/pull/4772
Removes the ADDROLE/REMOVEROLE Overseer Roles API (CollectionsHandler, ClusterAPI v2 commands, ClusterStatus.ROLES_PROP, CollectionAdminRequest.addRole/removeRole, the roles.json ZK node). Replacement is Node Roles (-Dsolr.node.roles), already in place. The internal re-prioritization signal (a node starting as overseer:preferred nudges the Overseer) reused the ADDROLE enum value and an OverseerRoleCmd class purely because they already existed. Renamed both (REPRIORITIZE_OVERSEER, OverseerPrioritizationCmd) instead of keeping a role-shaped name that needed a paragraph to explain. Orphaned by the removal, also deleted: CollectionsHandler.KNOWN_ROLES, ClusterAPI.RoleInfo, CollectionAdminParams.ROLE (0 remaining refs anywhere, confirmed each with a fresh grep after the previous deletion). Test coverage: two ADDROLE-only tests replaced with one test of the actual invariant (a preferred node takes over without waiting for the current Overseer to restart); RollingRestartTest deleted wholesale (its single @Test was 100% ADDROLE-dependent). Two ref-guide pages updated: the ADDROLE/REMOVEROLE sections removed from cluster-node-management.adoc (including a stale roles response field in the CLUSTERSTATUS example), and a new major-changes-in-solr-11.adoc page added with an upgrade note. 33 tests, 0 failures. Simulated merge against all 4 open PRs sharing a file with this one (#4767/#4768/#4769/#4770) together -- applies clean. AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
