adityamparikh commented on PR #111: URL: https://github.com/apache/solr-mcp/pull/111#issuecomment-5357781172
Two updates. **Added the doc correction this PR invalidates (ab1aa24).** The Solr 10 Compatibility section said `getCacheMetrics()`/`getHandlerMetrics()` "catch `RuntimeException` (which covers `RemoteSolrException`)" — untrue the moment this merges, so the fix belongs here rather than trailing behind. It now also records *why* the narrower catch is correct, which the old wording didn't. (`CLAUDE.md` is a symlink to `AGENTS.md`, so that's the single source.) **Resolved a collision with #110.** Both PRs rewrite the same two catch clauses — this one narrows `RuntimeException` to `SolrException`, #110 was binding the exception for logging while leaving `RuntimeException` in place. Whichever merged second would have conflicted or silently reverted the other. #110 now carries the narrowed form too (506f2bb), so the end state is identical in either merge order and neither blocks the other. For the record, the narrowing is safe: `RemoteSolrException extends SolrException` in solrj 10.0.0, verified against the jar rather than from memory, so Solr 10's missing `/admin/mbeans` still degrades to `null`. What stops being swallowed is unrelated runtime failures — which is the point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
