adityamparikh opened a new pull request, #188:
URL: https://github.com/apache/solr-mcp/pull/188

   ## What
   
   Upgrades the Gradle wrapper from **9.4.1 → 9.7.1** and sets `retries=3` for 
distribution downloads.
   
   Generated with `./gradlew wrapper --gradle-version 9.7.1 --distribution-type 
bin`, run twice so the wrapper jar is regenerated by 9.7.1 itself rather than 
left as the 9.4.1 copy.
   
   ## Why this is the whole change
   
   Nothing outside the wrapper pins a Gradle version — no workflow under 
`.github/` and no entry in `gradle/libs.versions.toml` names one, since CI 
invokes `./gradlew`. So `gradle-wrapper.properties` is the single source of 
truth.
   
   ## About `retries=3`
   
   The 9.7.1 generator emits two properties that did not exist in 9.4.1's 
output:
   
   ```properties
   retries=3          # generated default is 0
   retryBackOffMs=500
   ```
   
   These govern retrying the download of the Gradle distribution itself. That 
happens *before* Gradle exists locally, so it is not reachable from 
`build.gradle.kts`. The generated default `retries=0` means one attempt and 
then fail, which turns a transient blip fetching `services.gradle.org` into a 
red build rather than a retry — expensive on this project, where fork PRs sit 
in an approval-gated CI queue and a re-run is not cheap.
   
   `networkTimeout=10000` is a separate knob: it bounds a single attempt, it 
does not retry.
   
   This is the one deliberate deviation from generated output. Setting it back 
to `0` would keep the file byte-identical to what `gradle wrapper` produces, at 
the cost of that resilience.
   
   ## Verification
   
   Full `./gradlew build` on JDK 25:
   
   ```
   BUILD SUCCESSFUL
   :rat, :spotlessJavaCheck, :test, :check all executed (not up-to-date)
   372 tests · 0 failures · 0 errors · 7 skipped
   ```
   
   Gradle's embedded Kotlin moves 2.x → 2.4.0, which is the notable 
compatibility surface here since `buildSrc` uses `kotlin-dsl` and its 
convention plugins recompile against it. They compile clean.
   
   ## Note for later (no action in this PR)
   
   The build now reports "incompatible with Gradle 10". That resolves to 
exactly one deprecated call — `ReportingExtension.file(String)` — and `grep` 
over `build.gradle.kts` and `buildSrc/src/main/kotlin/` finds no such call in 
this repo's own scripts. It comes from a third-party plugin and will clear on a 
plugin bump; no build-script change is needed here.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to