janhoy opened a new pull request, #4786: URL: https://github.com/apache/solr/pull/4786
https://issues.apache.org/jira/browse/SOLR-18394 Test-framework-only refactor of `JettyConfig`, prompted by review feedback in #4738 that the 10-arg private constructor had gotten out of control. * The private constructor now takes the `Builder` and reads fields directly from it * `Builder` implements `Cloneable`; `build()` passes a clone so later builder mutation can't leak into a built config * `builder(JettyConfig other)` returns a clone of the config's builder snapshot, removing the manual field-by-field copy factory * Public final fields are unchanged — no call-site impact; maps remain shared on copy, matching previous semantics Adding a new Jetty option now only requires the builder field/setter and the public final field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
