serhiy-bzhezytskyy commented on PR #4777: URL: https://github.com/apache/solr/pull/4777#issuecomment-5385531477
Removed `createFromJson` entirely instead of un-deprecating it -- inlined its parse-then-`createFromCollectionMap` body at all 7 call sites (6 test, 1 production). Also removed `CoreContainer.setWeakStringInterner()`/`ClusterState.setStrInternerParser()`: that config only ever fed `createFromJson`'s parsing, and the real production path (`ZkStateReader.fetchCollectionState()`) already bypasses it with plain `Utils.fromJSON()`. Was already dead, now provably unreachable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
