[
https://issues.apache.org/jira/browse/SOLR-17461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18107136#comment-18107136
]
David Smiley edited comment on SOLR-17461 at 8/23/26 3:21 PM:
--------------------------------------------------------------
Surprisingly, this is basically, although not exactly, dead code:
https://issues.apache.org/jira/browse/SOLR-16328?focusedCommentId=18107135&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18107135
and so it'll be removed shortly in another PR pending on a related topic.
was (Author: dsmiley):
Surprisingly, this is basically, although not exactly, dead code: comment and
so it'll be removed shortly in another PR pending on a related topic.
> (cleanup) Move ClusterState string "Interner" json parser to Utils
> ------------------------------------------------------------------
>
> Key: SOLR-17461
> URL: https://issues.apache.org/jira/browse/SOLR-17461
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: Noble Paul
> Priority: Minor
> Labels: newdev, pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> ClusterState.setStrInternerParser and its functionality is potentially of
> general utility and it's also a bit distracting in ClusterState. I also
> don't like CoreContainer being involved in initializing it (CoreContainer is
> doing too much!). It's doing it because ClusterState is in SolrJ without
> Caffeine being on the classpath. Instead, imagine a class in solr-core that
> implements this Function. Utils could then self-initialize via reflection
> detecting if that class is available, otherwise gracefully resorting to the
> non-intern mechanism. No touching CoreContainer which is way too busy doing
> many things.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
