janhoy opened a new pull request, #4802: URL: https://github.com/apache/solr/pull/4802
https://issues.apache.org/jira/browse/SOLR-18399 ui-grid.min.css references `fonts/ui-grid.{woff,ttf,eot,svg}`, but the font files were never checked in, so grid icons on the Admin UI SQL screen render as boxes and the browser logs 404s for the fonts. # Solution Add the four icon font files to `solr/webapp/web/css/angular/fonts/`, taken from the same angular-ui-grid 4.10.0 release (MIT) that the already-shipped `ui-grid.min.css`/`ui-grid.min.js` come from. The war task packages everything under `web/`, so they ship automatically. Also remove the console-error filter in `AdminUiTestBase` that suppressed the font 404 as a known issue. # Tests `AdminUiSqlScreenTest` passes with the 404-filter removed. As a negative control, deleting the fonts again makes the test fail with the exact `fonts/ui-grid.woff`/`.ttf` 404 console errors, proving the test exercises the font requests. Full `:solr:webapp:check` with `-Ptests.selenium=true` (all 53 Admin UI browser tests, RAT, spotless) passes. No changelog entry: user-invisible packaging fix for the legacy Admin UI. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
