gerlowskija commented on code in PR #4799:
URL: https://github.com/apache/solr/pull/4799#discussion_r3842753602
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/SolrStream.java:
##########
@@ -68,18 +69,52 @@ public class SolrStream extends TupleStream {
private transient SolrClientCache clientCache;
private transient boolean doCloseCache;
+ // TODO SOLR-17995 proposes that we should deprecate this constructor in
favor of one of the other
+ // constructors that requires users to provide the core as an explicit
parameter
/**
- * @param baseUrl Base URL of the stream.
- * @param params Map<String, String> of parameters
+ * @param baseUrl URL of the Solr core or collection to query, typically of
the form
+ * "http://host:8983/solr/myCore";.
+ * @param params query-parameters sent with the streaming request
*/
public SolrStream(String baseUrl, SolrParams params) {
this.baseUrl = baseUrl;
this.params = params;
}
- SolrStream(String baseUrl, SolrParams params, String core) {
- this(baseUrl, params);
+ // TODO SOLR-17995 proposes that we should deprecate this constructor in
favor of one of the other
+ // constructors that requires users to provide the core as an explicit
parameter
+ /**
+ * @param baseUrl URL of the Solr core or collection to query, typically of
the form
+ * "http://host:8983/solr/myCore";.
+ * @param path the request handler path to query (e.g. "/export"). If not
provided, defaults to
+ * "/select".
+ * @param params query-parameters sent with the streaming request
+ */
+ public SolrStream(String baseUrl, String path, SolrParams params) {
+ this(baseUrl, null, path, params);
+ }
+
+ /**
+ * @param baseUrl the Solr node's "base" URL (i.e. no core or collection in
the path
+ * @param params query-parameters sent with the streaming request
+ * @param core the name of the collection or core to query; must be hosted
at {@code baseUrl}
+ */
+ public SolrStream(String baseUrl, SolrParams params, String core) {
Review Comment:
I agree. My ideal ordering is down in L113 below: URL then core then path
then params.
This constructor actually pre-exists this PR (despite the diff marking it
all as 'green') So whether I like it or not it'd be a breaking change to remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
