serhiy-bzhezytskyy opened a new pull request, #4807: URL: https://github.com/apache/solr/pull/4807
https://issues.apache.org/jira/browse/SOLR-18403 `SnapshotExportTool` built its `Backup` request with `setCommitName(snapshotName)` but never called `setIncremental(false)`. `commitName` is only read by the non-incremental backup path, so it was silently ignored and the export backed up the live index instead of the named snapshot -- no error, no warning. Verified with a real `MiniSolrCloudCluster` test: indexed 5 docs, snapshotted, indexed 5 more (live index now 10), exported, restored -- got 10 docs before this fix, 5 after. Confirmed the test actually catches the regression (reverted the one-line fix locally, test failed as expected, restored it). This predates incremental backups entirely -- the `commitName`-based export worked correctly before SOLR-13608 introduced `incremental` defaulting to `true` in 2021. That interaction was never revisited, and SOLR-17180 (2024) carried the bug forward unchanged when porting `snapshotscli.sh` into `bin/solr snapshot-export`. AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
