serhiy-bzhezytskyy opened a new pull request, #4808: URL: https://github.com/apache/solr/pull/4808
https://issues.apache.org/jira/browse/SOLR-18358 Removes `CollectionAdminRequest.Backup.setIncremental(boolean)` and the `incremental=false` ("full snapshot") backup path in `BackupCmd`, plus the `commitName`/`snapshotName` fields on `Backup` and the v2 REST request body -- `commitName` was only ever read inside the path being removed. `SnapShooter`'s own, separate `commitName` handling (the core-level `BACKUPCORE` action) is untouched -- checked, it has zero dependency on `incremental`, it's an independent capability outside this ticket's scope. `CoreAdminParams.COMMIT_NAME` is kept, since it's shared with the snapshot admin actions (CREATESNAPSHOT/etc). `BackupRestoreApiErrorConditionsTest`'s legacy-format-rejection test now builds its on-disk fixture by hand (can't create one via the removed API anymore); everything else is a straight collapse of `if (incremental)` branches. Related, and in tension with this PR: #4807 (SOLR-18403) fixes `bin/solr snapshot-export` to correctly use `commitName`+`incremental=false` -- the exact capability this PR removes. If both land, #4807's fix becomes moot. Flagging for whoever reviews either one; not resolving the sequencing here. AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
