gerlowskija opened a new pull request, #4816: URL: https://github.com/apache/solr/pull/4816
https://issues.apache.org/jira/browse/SOLR-18332 # Description The 'qt' parameter and several related methods in SolrJ are deprecated. This deprecation may not stick, but it's still worth minimizing use of this feature as much as possible. One place where 'qt' is still used frequently is in CloudSolrStream (and related "expression" strings. # Solution This PR addresses this similarly to the recent #4747 : by giving CloudSolrStream and friends a constructor parameter that allows users to specify the path at creation-time instead of relying on "qt". CloudSolrStream is also an "Expressible", meaning that it maps to our user-facing streaming-expression syntax. So this PR also adds "path" as a parameter name in that syntax. (I used Claude to help me investigate and write some of this PR; especially the test updates.) # Tests Various streaming tests have been updated to use the new "path" streaming expression parameter name. A test-case has been added with the explicit purpose of testing the non-preferred "qt" syntax that was supported prior to this PR. Existing tests continue to pass. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
