HoustonPutman commented on code in PR #4804:
URL: https://github.com/apache/solr/pull/4804#discussion_r3864543855
##########
solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc:
##########
@@ -435,6 +435,9 @@ of the distributed query processing.
== segmentTerminateEarly Parameter
+WARNING: Deprecated since 11.0. Its implementation relies on internal Lucene
behavior that cannot
+currently be replicated using Lucene's own public early-termination support
(see SOLR-18363).
+
Review Comment:
When deprecating, we should mention that minExactCount is the new parameter
which controls when the search will be terminated early. This should be
mentioned in the changelog as well.
##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -1802,11 +1799,74 @@ TopDocsCollector<? extends ScoreDoc>
buildTopDocsCollector(int len, QueryCommand
final CursorMark cursor = cmd.getCursorMark();
final FieldDoc searchAfter = (null != cursor ?
cursor.getSearchAfterFieldDoc() : null);
+ if (allowNativeSegmentTerminateEarly) {
+ minNumFound = 0;
Review Comment:
shouldn't this be `len`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
