NextbrickInc commented on code in PR #4774: URL: https://github.com/apache/solr/pull/4774#discussion_r3867140962
########## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/OnDisconnect.java: ########## Review Comment: @HoustonPutman Thanks for the feedback. My intent with the listener-level change was to centralize the LOST → RECONNECTED semantics and prevent consumers from accidentally treating a transient SUSPENDED → RECONNECTED cycle as session expiration. The weak listener tracking also avoided changing the callback signatures. That said, I agree it broadens the responsibility of the shared interfaces and introduces state outside the components that actually perform recovery. Keeping OnDisconnect and OnReconnect unchanged and tracking LOST locally with an AtomicBoolean in ZkController and ZkStateReader is better scoped and easier to remove later. I’ll rework the implementation and update the regression tests accordingly. Please let me know if you need anything else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
