potiuk commented on PR #160: URL: https://github.com/apache/solr-mcp/pull/160#issuecomment-5438257299
Thanks @adityamparikh — that re-verification against `main` rather than against the review thread is the right way to check a document like this, and the JWT audience point is exactly the claim I'd have wanted someone to go and confirm independently. Nothing outstanding from our side. To answer @epugh's question directly: **yes, this is ready to merge whenever a committer wants to click it.** No blockers, no pending changes, and it merges clean. On the `stateless` observation — agreed it's orthogonal to the transport name and not a correction, so I'd rather not churn the PR for it. If it turns out to matter, the sharper framing for a follow-up is that `spring.ai.mcp.server.protocol=stateless` disables the per-request context features (sampling, progress, server→client logging), which is a property worth stating in §5a only if something downstream starts relying on them being available. Happy to open that as a separate PR after this lands if you want it captured. One practical note on why it's worth landing rather than leaving open: merging this puts `AGENTS.md` → `SECURITY.md` → `THREAT_MODEL.md` on the default branch, which is the chain a scan agent follows to find a project's model. `apache/solr-mcp` is the one repo in Solr's requested scope that isn't discoverable yet, so this PR is the last thing between it and eligibility for a scan. No urgency attached — just so the merge isn't sitting there looking purely cosmetic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
