gerlowskija commented on code in PR #4775:
URL: https://github.com/apache/solr/pull/4775#discussion_r3880300988
##########
solr/core/src/java/org/apache/solr/handler/admin/api/GetNodeProperties.java:
##########
@@ -57,6 +57,8 @@ public NodePropertiesResponse getNodeProperties() {
@PermissionName(PermissionNameProvider.Name.CONFIG_READ_PERM)
public NodePropertiesResponse getNodeProperty(String propertyName) {
final NodeConfig nodeConfig = coreContainer.getNodeConfig();
+ // Hidden names always return 200 + a redacted value, even if unset, so
callers cannot
Review Comment:
This comment is super helpful, thank you! 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
