dsmiley opened a new pull request, #4825: URL: https://github.com/apache/solr/pull/4825
Both were derived from the first segment's LeafMetaData only, which is wrong once the composite view has more than one leaf: - sort() claimed the first segment's index sort even when stacking multiple segments end-to-end, which does not preserve that sort as a whole. Consumers act on the claim (TopFieldCollector stops collecting a leaf once the search sort is a prefix of the index sort), so a search over this wrapper could silently drop hits. - hasBlocks() reported false whenever segment 0 happened to have no blocks, even if a later segment did. sort() is now null except in the trivial single-leaf case; hasBlocks() is now the OR across all leaves, since a block is never split across segments. _disclaimer: saw this in an experiment/hack; didn't see in the real world nor in existing tests _ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
