dsmiley commented on code in PR #4750:
URL: https://github.com/apache/solr/pull/4750#discussion_r3881798461
##########
solr/cross-dc-manager/src/test/org/apache/solr/crossdc/manager/messageprocessor/TestMessageProcessor.java:
##########
@@ -72,6 +73,10 @@ public static void ensureWorkingMockito() {
public void setUp() {
MockitoAnnotations.initMocks(this);
+ // handleItem() probes the cluster through the state provider, so the mock
must supply one
Review Comment:
You caught the reason why CI was failing & fixed; thanks. I hate mocks --
returning null when the *real* thing would never do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
