epugh opened a new pull request, #4837: URL: https://github.com/apache/solr/pull/4837
# Description Split out from #4743 into smaller, per-module PRs to make review easier. This PR contains the tidy-up changes to `solr/modules/ltr` (production + test code). # Solution Leverage IntelliJ warnings (dead field/method removal, `toString()`/`this` interchange, `isEmpty()` idioms, javadoc/comment fixes, `interlavingAlgorithm` → `interleavingAlgorithm` field rename, `TestUserTermScorereQDF` → `TestUserTermScorerQDF` typo-fix rename). **One non-cosmetic change to flag explicitly:** `TestWrapperModel.java`'s `testOverwrittenMethods()` now skips `private` methods when reflecting over `LTRScoringModel`'s declared methods. Without this, `LTRScoringModel`'s private `calculateHashCode()` was being picked up as "overridable" and the test incorrectly demanded `WrapperModel` declare an override for it. This is a genuine test bug fix, not just tidying — calling it out here so it doesn't get missed in review. # Tests existing Relates to #4743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
