epugh commented on code in PR #4832:
URL: https://github.com/apache/solr/pull/4832#discussion_r3898789283
##########
solr/modules/extraction/src/java/org/apache/solr/handler/extraction/ExtractingParams.java:
##########
@@ -135,27 +135,26 @@ public interface ExtractingParams {
* i.e. the first match will be used If you want a fallback password to be
always used, supply a
* .*=<defaultmypassword> at the end
*/
- public static final String PASSWORD_MAP_FILE = "passwordsFile";
+ String PASSWORD_MAP_FILE = "passwordsFile";
/** Backend selection */
- public static final String EXTRACTION_BACKEND = "extraction.backend";
+ String EXTRACTION_BACKEND = "extraction.backend";
/** Preferred: Fix/normalize metadata naming for Tika Server compatibility */
- public static final String TIKASERVER_METADATA_COMPATIBILITY =
- "tikaserver.metadata.compatibility";
+ String TIKASERVER_METADATA_COMPATIBILITY =
"tikaserver.metadata.compatibility";
/** URL of Tika Server instance. */
- public static final String TIKASERVER_URL = "tikaserver.url";
+ String TIKASERVER_URL = "tikaserver.url";
/** Max characters allowed in parsed content */
- public static final String TIKASERVER_MAX_CHARS = "tikaserver.maxChars";
+ String TIKASERVER_MAX_CHARS = "tikaserver.maxChars";
/**
* Enable recursive parsing of embedded documents when using TikaServer.
This is experimental,
* uses /rmeta endpoint, uses more RAM and is disabled by default.
*/
- public static final String TIKASERVER_RECURSIVE = "tikaserver.recursive";
+ String TIKASERVER_RECURSIVE = "tikaserver.recursive";
Review Comment:
Totally no idea! Maybe an opportunity for deeper refactorigns, this PR was
pretty lmited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
