sigram commented on code in PR #4831:
URL: https://github.com/apache/solr/pull/4831#discussion_r3904241050
##########
solr/cross-dc-manager/src/java/org/apache/solr/crossdc/manager/consumer/PartitionManager.java:
##########
@@ -41,16 +39,52 @@ public class PartitionManager {
new ConcurrentHashMap<>();
private final KafkaConsumer<String, MirroredSolrRequest<?>> consumer;
- static class PartitionWork {
+ @VisibleForTesting
+ public static class PartitionWork {
Review Comment:
Kafka does provide this when auto-commit mode for offsets is used. We
explicitly don't want this because we don't want to automatically advance the
topic offset beyond what was actually successfully processed and sent to Solr.
When doing things manually this becomes more complicated - whether it needs
to be *this* complicated I'm not sure, it's a design question beyond the scope
of this bug fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
