adityamparikh commented on PR #159: URL: https://github.com/apache/solr-mcp/pull/159#issuecomment-5650646094
Re-reviewed the current head (`ad5b94a`). Every earlier inline request is addressed: `getAliases()`, `idempotentHint` on create, `destructiveHint` on delete, the `@JsonFormat` timestamp, `TEST_COLLECTION_2`, and the Testcontainers test. Two things stand between this and merge: 1. **Rebase conflict, one line.** `main` renamed `MCP_RESPONSE_RECORDS` to `MCP_TOOL_RECORDS` in `SolrNativeHints` (and added `SortClause` to it). Add `AliasResult.class` to `MCP_TOOL_RECORDS` when you rebase; that is the only conflict `git merge-tree` reports. 2. **Registration test coverage.** `McpToolRegistrationTest` enumerates Search/Indexing/Collection/Schema for the tool-name uniqueness and annotation checks; the three alias tools are not in it. Please add `addToolNames(AliasService.class, toolNames)` and an `AliasService` annotations case so the invariant covers them. Two optional nits: `collections` is passed to Solr verbatim, so `"a, b"` reaches the alias API with the space (strip or split/rejoin); and the `getStatus() == 0` branches at lines 166/210 are unreachable because `process()` throws on failure. The red "CI / Build" is not this PR. The 2026-09-11 re-run died downloading the Gradle wrapper distribution (`Connection reset by peer`) before compiling anything; unit and integration jobs were skipped. A re-run should go green. @epugh, could you kick it off after the rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
